Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement graceful in Passenger Standalone (builtin) #1598

Closed
FooBarWidget opened this issue Sep 2, 2015 · 6 comments
Closed

Implement graceful in Passenger Standalone (builtin) #1598

FooBarWidget opened this issue Sep 2, 2015 · 6 comments

Comments

@FooBarWidget
Copy link
Member

Passenger Standalone does not currently support graceful shutdown. We should implement support for this. This may require changes in daemon_controller.

  • When using the Nginx engine, this can be made to work by sending SIGQUIT instead of SIGTERM.
  • I have not yet investigated how this can be made to work with the builtin engine. Having said that, the ServerKit::HttpServer class supports graceful shutdown. We may not have properly integrated this in CoreMain.cpp or in the Watchdog.
@meoooh
Copy link

meoooh commented Oct 12, 2016

Any changes?

@CamJN
Copy link
Contributor

CamJN commented Nov 11, 2016

No, there haven't been any changes on this front yet.

@PikachuEXE
Copy link
Contributor

When will this be implemented...

@PikachuEXE
Copy link
Contributor

PikachuEXE commented Jun 13, 2017

Also SIGQUIT seems being used for printing

In case of Ruby applications, you can also send the 'SIGQUIT' signal to have it print

a backtrace without aborting

Edit:
And SIGQUIT cannot be used by JRuby:

* Sending SIGBART to a Ruby process will now trigger the same behavior

Edit 2:
Also looking at

def trapsafe_shutdown_and_cleanup(error_occurred)

I am not sure if it's implemented already or not

@PikachuEXE
Copy link
Contributor

Please look at #1956 for possible implementation for Nginx engine

OnixGH pushed a commit that referenced this issue Jul 12, 2017
This PR fulfills the Nginx part of GH-1598.
[ci:skip]
@OnixGH OnixGH changed the title Implement graceful in Passenger Standalone Implement graceful in Passenger Standalone (builtin) Jul 12, 2017
@CamJN
Copy link
Contributor

CamJN commented Mar 12, 2018

Added in 5.1.6

@CamJN CamJN closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants