Remove erroneous include statement for FreeBSD #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clemens Gruber <clemensgru@gmail.com>
|
Thanks for this pull request. Are you sure pcpu.h is not needed? I included it because it was present in vmstat.c. Have you also tested this on older FreeBSD versions? |
|
Hi, as far as I understand, the |
OnixGH
added a commit
that referenced
this pull request
Mar 5, 2015
Remove unused include statement for FreeBSD that confuses the build
|
@OnixGH Could you update the changelog too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we should include
sys/pcpu.hhere. It leads to the build error described in #1401This PR should fix it. On my FreeBSD 10.1 box, the build error did not occur anymore!
Signed-off-by: Clemens Gruber clemensgru@gmail.com