Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow soft termination signal to be sent more than once #55

Merged
merged 1 commit into from Jun 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

ehlertij commented Jun 4, 2012

Currently, if you send the SOFT_TERMINATION_SIGNAL more than once to a passenger process it will throw a cryptic error on the 2nd signal.

This pull request essentially ignores all subsequent soft termination signals and allows the request to finish processing.

  • I can't get RSpec working right now for some reason, but I'll try to get it going and write some tests for this.
Owner

FooBarWidget commented Jun 5, 2012

Thanks Ian, this patch looks good. We require contributors to sign our contribution agreement before we can pull in their patches. Could you sign it?

Contributor

ehlertij commented Jun 5, 2012

Just finished submitting the form, let me know if there's anything else you need.

@FooBarWidget FooBarWidget added a commit that referenced this pull request Jun 5, 2012

@FooBarWidget FooBarWidget Merge pull request #55 from ehlertij/master
Allow soft termination signal to be sent more than once
f51c1f5

@FooBarWidget FooBarWidget merged commit f51c1f5 into phusion:master Jun 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment