Use LB server if API URL is empty #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subjut What do you think? |
|
I can't test it right now, but the code looks good. I like the preference pane cue. And the clarifications in the README are good. I hope people actually read it. The |
Yes. I also had to spend a few minutes looking up the proper URL, even though I knew what I was looking for. That's why I made it so explicit in the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the API URL preference to use the ListenBrainz server if it is empty. This simplifies the configuration a bit as it is easier to go back to default config. If the text edit field is empty it shows the default URL as a cue.
Also extends the README a bit, explicitly describing setup with Maloja (as it might be a common use case).