Updated WebserverCommand to use local ontologies if available #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlapp
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
What remains a bit confusing is whether this will always look for local ontologies (or only if the HTTP IRIs fail to dereference), and whether a local ontology if found will supersede the online version.
Also, Protégé actually has had to solve the same problem, and does this by writing (and subsequently reading) a catalog.xml file. This may go past the scope of this PR but couldn't we reuse that?
|
Yup, I hadn't realized that XML catalogs were an open standard! I've opened an issue for implementing them in #28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestCommand (
java -jar jphyloref.jar test ...) already supports the use of local ontologies if they are available. This PR adds support for reading ontologies from the same folder to WebserverCommand (java -jar jphyloref.jar webserver ...) as well.