-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PLV handling to be more isolated and dynamic #328
Comments
@matsen Should we also take this opportunity to rename the PLV enums? Since the GP paper has moved away from the tilde notation? |
@davidrich27 YES!!! And also make them compliant with the capitalization convention. |
* Adds PLVHandler, a static class of methods to facilitate GPOperations accessing PLV indices in the GPEngine. * Renames PLV Enums to reflect current naming conventions in GP paper. Closes #328
@matsen Do you want to transpose PLVs from (plv_idx, node_idx) to (node_idx, plv_idx)? |
That seemed like a good thing to do if we wanted to be able to expand the number of nodes later, but how we do all of this is up to you! |
Right now the PLV management in GPDAG is built in. We should have this factored out into a separate class that only knows about PLVs and likelihoods.
Also, the PLVs for GP are currently numbered in a way that is not so friendly for expanding the number of nodes:
That shouldn't be hard to "transpose".
The text was updated successfully, but these errors were encountered: