Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename subsplit DAG elements #350

Open
matsen opened this issue Jul 31, 2021 · 2 comments
Open

Rename subsplit DAG elements #350

matsen opened this issue Jul 31, 2021 · 2 comments
Assignees

Comments

@matsen
Copy link
Collaborator

matsen commented Jul 31, 2021

Here are some proposals. Add yours as well!

  • dag root -> universal ancestor (ua)
  • rotated -> left, and sorted -> right
  • PCSP -> edge
  • fake subsplit -> leaf subsplit

Let's discuss and come to consensus before making any change.

@matsen
Copy link
Collaborator Author

matsen commented Jul 31, 2021

This isn't quite a naming issue, but I wonder how we decided to have the DAG root have bitset 1111|0000 rather than having the zeroes first. Did we want to have things come down through the rotated edge? cc @shokiami @tanviganapathy

@davidrich27 davidrich27 self-assigned this Sep 20, 2021
@davidrich27
Copy link
Collaborator

davidrich27 commented Oct 14, 2021

  • Chunks (and child in subsplit constructor) -> clades

  • Make left and right clade as enumerated types for subsplits?

  • Make sister, focal and left-child as enumerated types for edges (formerly PCSP)?

  • Not a rename, but I would like to put forward the idea of Internal vs External nodes and edges. Internal nodes are subsplits which do not go out to an extremity (a leaf or a root). Internal edges are edges for which neither the parent nor child are external.

@davidrich27 davidrich27 added this to To do in generalized pruning via automation Oct 14, 2021
@davidrich27 davidrich27 moved this from To Do to In Progress in generalized pruning Oct 14, 2021
@davidrich27 davidrich27 moved this from In Progress to Done in generalized pruning Feb 9, 2022
matsen added a commit that referenced this issue Feb 16, 2022
@matsen matsen mentioned this issue Feb 17, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants