ci: protect against surreptitious lockfile changes #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `poetry lock --no-update` command is added to all the workflows where `poetry` is used to install an environment from the lockfile. Doing so "refreshes" the lockfile and will remove any entries in the lockfile that are not actually dependencies of packages defined in the `pyproject.toml` file. It does not produce an error or non-zero return code when changes are made, but at least the lockfile will be in a better state before it gets used.
Arbitrary code execution can occur when building/installing packages from source distributions. This test guards against changes to the established/vetted build system. There may be legitimate times to change the build system requirements and/or backend, but those changes will be more apparent in code reviews since this test will also have to change. Changes to the values in the `pyproject.toml` file may be subtle and go unnoticed. In the worst case, it is possible for the values to be changed to malicious entries that seek to cause harm in CI systems.
maxrake
requested review from
andreaphylum and
kylewillmon
and removed request for
andreaphylum
Phylum OSS Supply Chain Risk Analysis - INCOMPLETEThe analysis contains 1 package(s) Phylum has not yet processed, |
Phylum OSS Supply Chain Risk Analysis - SUCCESSThe Phylum risk analysis is complete and has passed the active policy. |
Phylum OSS Supply Chain Risk Analysis - INCOMPLETEThe analysis contains 1 package(s) Phylum has not yet processed, |
Phylum OSS Supply Chain Risk Analysis - SUCCESSThe Phylum risk analysis is complete and has passed the active policy. |
cd-work
requested changes
Apr 27, 2023
cd-work
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to be merged...but only after some changes are made to the lockfile. It is being used to demonstrate an attack where the lockfile is updated surreptitiously and the changes are attempted to be approved through a PR, due to the way GitHub's
linguistlibrary hides/collapses known lockfiles.The real changes made here include:
poetry lock --no-updatecommand is added to all the workflows wherepoetryis used to install an environment from the lockfilepyproject.tomlfile