Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug which is preventing one from selecting the first role #13

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Oct 18, 2017

Without this fix, it seems like you just get prompted for a choice again and again even though you've input 0:

$ onelogin-aws-login
Onelogin Username: mumoshu@example.com
Onelogin Password:
OTP Token: 936070
[0] arn:aws:iam::$myaccountid:role/myrole1
[1] arn:aws:iam::$myaccountid:role/myrole2
[2] arn:aws:iam::$myaccountid:role/myrole3
Role Number: 0
Role Number: 0
Role Number: 0
...

@physera Btw, thanks for sharing the great project 👍 Hope this helps.

Without this fix, it seems like you just get prompted for a choice again and again even though you've input `0`:
```
$ onelogin-aws-login
Onelogin Username: mumoshu@example.com
Onelogin Password:
OTP Token: 936070
[0] arn:aws:iam::$myaccountid:role/myrole1
[1] arn:aws:iam::$myaccountid:role/myrole2
[2] arn:aws:iam::$myaccountid:role/myrole3
Role Number: 0
Role Number: 0
Role Number: 0
...
```
Copy link
Contributor

@cameronmarlow cameronmarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Thanks for the quick fix. I'll bump the version and release soon.

@cameronmarlow cameronmarlow merged commit 2c2fa1e into physera:master Oct 18, 2017
@mumoshu mumoshu deleted the fix-1st-role-choice branch October 18, 2017 03:52
drewsonne pushed a commit to drewsonne/onelogin-aws-cli that referenced this pull request Jan 24, 2018
…sera#13)

Without this fix, it seems like you just get prompted for a choice again and again even though you've input `0`:
```
$ onelogin-aws-login
Onelogin Username: mumoshu@example.com
Onelogin Password:
OTP Token: 936070
[0] arn:aws:iam::$myaccountid:role/myrole1
[1] arn:aws:iam::$myaccountid:role/myrole2
[2] arn:aws:iam::$myaccountid:role/myrole3
Role Number: 0
Role Number: 0
Role Number: 0
...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants