Support for building self-contained binaries for easier installation #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `scripts/build.sh` which produces a pex binary `dist/onelogin-aws-login`. The pex binary supports multiple archs/platforms - currently, it is runnable on both linux/macOS, x86_64/i686. The existing way to install onelogin-aws-login with `pip install` is still supported. Note that a pex binary doesn't contain a python runtime. You still need to install python3 in order to run the onelogin-aws-login command. However, this will still allow you to install onelogin-aws-login without polluting your python env. Also, installing onelogin-aws-login is easier as it is just a matter of running `curl -o onelogin-aws-login <onelogin-aws-login release> && chmod +x onelogin-aws-login`. Resolves physera#29 --- This is verified to work by: - Running `pip install -e .` and then `onelogin-aws-login` - Running `scripts/build.sh` and then `dist/onelogin-aws-login` - Running `docker build -t onelogin-aws-login-test .` with Dockerfile: ``` FROM alpine:3.7 RUN apk add --update --no-cache python3 ADD dist/onelogin-aws-login / ``` and running `docker run --rm -it onelogin-aws-login /onelogin-aws-login -h`
|
Apologies for the late response. Thanks for submitting this, we'd love to get it in! Could you update the conflicts on the PR to accommodate some other changes that have landed in the interim? |
|
@slycoder No worry, thanks for taking your time! Just fixed the conflict - resolving it produced no commit diff because it was just due to a fix to a line-ending. |
|
@slycoder Just for your notice, the last travis build for this is failing due to the same errors seen in the current master. |
|
Sorry about the delay. I'll go ahead and merge. |
drewsonne
pushed a commit
to drewsonne/onelogin-aws-cli
that referenced
this pull request
Feb 20, 2018
…llation (physera#30)" (physera#42) This reverts commit e54a44c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
scripts/build.shwhich produces a pex binarydist/onelogin-aws-login.The pex binary supports multiple archs/platforms - currently, it is runnable on both linux/macOS, x86_64/i686.
The existing way to install onelogin-aws-login with
pip installis still supported.Note that a pex binary doesn't contain a python runtime. You still need to install python3 in order to run the onelogin-aws-login command.
However, this will still allow you to install onelogin-aws-login without polluting your python env. Also, installing onelogin-aws-login is easier as it is just a matter of running
curl -o onelogin-aws-login <onelogin-aws-login release> && chmod +x onelogin-aws-login.Resolves #29
This is verified to work by:
pip install -e .and thenonelogin-aws-loginscripts/build.shand thendist/onelogin-aws-logindocker build -t onelogin-aws-login-test .with Dockerfile:docker run --rm -it onelogin-aws-login /onelogin-aws-login -h