Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace utils.check_input_dir() with os.path.abspath() #368

Merged
merged 4 commits into from Dec 10, 2020

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Dec 9, 2020

Closes #335

Replace utils.check_input_dir() with os.path.abspath().

Proposed Changes

  • Replace utils.check_input_dir() with os.path.abspath() in all functions
  • Delete function from utils.py
  • Delete unit tests

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer vinferrer added Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Refactoring Improve nonfunctional attributes labels Dec 9, 2020
@vinferrer vinferrer requested a review from smoia December 9, 2020 08:07
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #368 (c9ddc8e) into master (42bbffd) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   94.64%   94.61%   -0.03%     
==========================================
  Files           8        8              
  Lines         840      836       -4     
==========================================
- Hits          795      791       -4     
  Misses         45       45              
Impacted Files Coverage Δ
phys2bids/utils.py 98.43% <ø> (-0.10%) ⬇️
phys2bids/phys2bids.py 88.06% <100.00%> (ø)

@vinferrer vinferrer marked this pull request as ready for review December 9, 2020 08:13
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@vinferrer vinferrer requested review from tsalo, 62442katieb and sangfrois and removed request for smoia December 10, 2020 09:21
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eurunuela eurunuela merged commit ee03e2a into physiopy:master Dec 10, 2020
@smoia smoia removed the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Improve nonfunctional attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace utils.check_input_dir() with os.path.abspath() or pathlib Path object
4 participants