Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that would impede building the docs #399

Merged
merged 1 commit into from May 14, 2021

Conversation

eurunuela
Copy link
Collaborator

@eurunuela eurunuela commented May 14, 2021

Closes #397

Proposed Changes

  • Renames the call to two functions that failed due to sphinx updates.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@eurunuela eurunuela added Documentation This issue or PR is about the documentation BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) labels May 14, 2021
@eurunuela eurunuela requested a review from smoia May 14, 2021 14:18
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #399 (a727f6b) into master (586d7ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files           8        8           
  Lines         868      868           
=======================================
  Hits          823      823           
  Misses         45       45           

@smoia smoia removed the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label May 14, 2021
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since it's minor, I'm going to merge. Thanks!

@smoia smoia changed the title Fixed bug that would impede building the docs Fix bug that would impede building the docs May 14, 2021
@smoia smoia self-assigned this May 14, 2021
@smoia smoia merged commit 89aeabf into physiopy:master May 14, 2021
@smoia
Copy link
Member

smoia commented Jun 18, 2021

🚀 PR was released in 2.6.0 🚀

@smoia smoia added the released This issue/pull request has been released. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation This issue or PR is about the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs won't build
2 participants