Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing enviroment by using apt-get install build-essential rather than apt-get install make #413

Merged
merged 8 commits into from Nov 15, 2021

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Oct 26, 2021

Closes #411

Proposed Changes

  • Use apt-get install build-essential rather than apt-get install make

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer vinferrer requested a review from smoia October 26, 2021 13:36
@vinferrer vinferrer added the Testing This is for testing features, writing tests or producing testing code label Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #413 (fcabaf1) into master (6996d73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files           8        8           
  Lines         868      868           
=======================================
  Hits          823      823           
  Misses         45       45           

@vinferrer vinferrer marked this pull request as ready for review October 26, 2021 13:58
@vinferrer vinferrer added the Urgent If you don't know where to start, start here! label Oct 26, 2021
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smoia smoia merged commit 7369827 into physiopy:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing This is for testing features, writing tests or producing testing code Urgent If you don't know where to start, start here!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI cannot set up environment correctly
2 participants