Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: link related spaces / properties directly #73

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: link related spaces / properties directly #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e11e49
fix: link related spaces / properties directly
jamesdabbs Nov 6, 2023
0ac184d
ci: remove unused fixture data
jamesdabbs Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/viewer/cypress/e2e/deduction.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ it('shows derived proofs', () => {
cy.contains('T1')
cy.contains('119').click()

cy.url().should('match', new RegExp('/theorems/T000119$'))
cy.location('pathname').should('eq', '/theorems/T000119')
})

it('derives multi-step proofs', () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/viewer/cypress/e2e/search.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ describe('with a working remote', () => {
cy.get('input[name="text"]').type('plank')
cy.get('input[name="q"]').type('metacom')

cy.url().should('include', 'text=plank').should('include', 'q=metacom')
cy.location('search')
.should('include', 'text=plank')
.should('include', 'q=metacom')

cy.contains('Dieudonné plank')
})
Expand Down
21 changes: 21 additions & 0 deletions packages/viewer/cypress/e2e/space.spec.ts
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the newly added regression test.

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { deduce, setup } from '../support'

beforeEach(setup)

it('links to properties', () => {
cy.visit('spaces/S000004/properties')
deduce()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are increasingly adding these "wait for deduction" blocks, we want to make sure that deduction run stays fast (and – importantly – within the timeout).


cy.contains('Semiregular').click()

cy.location('pathname').should('eq', '/properties/P000010')
})

it('links to traits', () => {
cy.visit('spaces/S000004/properties')
deduce()

cy.contains('Semiregular').closest('tr').find('.bi-check').click()

cy.location('pathname').should('eq', '/spaces/S000004/properties/P000010')
})
Loading