Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default theme to auto light/dark theme #2006

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Change default theme to auto light/dark theme #2006

merged 1 commit into from
Dec 16, 2021

Conversation

yubiuser
Copy link
Member

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Sets the default theme to auto mode (dark/light).
Fixes pi-hole/pi-hole#4467

For discussion.

@yubiuser yubiuser added Discussion PR: Approval Required Open Pull Request, needs approval labels Dec 15, 2021
Relluem94
Relluem94 previously approved these changes Dec 16, 2021
View reviewed changes
DL6ER
DL6ER previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this change.

@DL6ER
Copy link
Member

DL6ER commented Dec 16, 2021

PHPStan should work if you rebase your PR on latest devel

@yubiuser
Change default theme to auto light/dark theme
a1904e2 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser dismissed stale reviews from DL6ER and Relluem94 via a1904e2 December 16, 2021 11:19
@yubiuser
Copy link
Member Author

Rebased. Phpstan passed. Needs re-approval.

@yubiuser yubiuser merged commit e76a03b into devel Dec 16, 2021
@yubiuser yubiuser deleted the default_theme branch December 16, 2021 20:35
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
Merged
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

This was referenced Dec 22, 2021
Merged
Merged
Closed
Merged
Merged
This was referenced Jan 3, 2022
Merged
Closed
@renovate renovate bot mentioned this pull request Mar 5, 2022
Merged
1 task
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/default-theme-use-prefers-color-scheme-to-detect-system-theme/35615/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

@Relluem94 Relluem94 Relluem94 left review comments

Assignees
No one assigned
Labels
Discussion PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yubiuser @DL6ER @pralor-bot @Relluem94