Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize summary numbers #2029

Merged
merged 2 commits into from
Dec 26, 2021
Merged

Localize summary numbers #2029

merged 2 commits into from
Dec 26, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 26, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

See title

How does this PR accomplish the above?:

Ensure number formatting is taking place in browser-scope to use client- instead of browser-based number localization. This relies on the locale being correctly applied in the user's browser.

Screenshots

ezgif-5-ebd4f24c10

What documentation changes (if any) are needed to support this PR?:

None

…nt- instead of browser-based number localization

Signed-off-by: DL6ER <dl6er@dl6er.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/change-decimal-and-thousands-separators-in-dashboard-according-to-local-settings/31168/12

@yubiuser
Copy link
Member

Can you include a fix for the long-term database as well?

https://github.com/pi-hole/AdminLTE/blob/193fb7fcb9daff08eae5b48ab9895dd35bff4233/scripts/pi-hole/js/db_queries.js#L151-L176

At least for me, the percentage got an . instead of a ,

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Dec 26, 2021

Left is English, Right is German browser

Screenshot from 2021-12-26 18-20-43

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm working

@yubiuser yubiuser merged commit 88039ae into devel Dec 26, 2021
@yubiuser yubiuser deleted the tweak/localized_numbers branch December 26, 2021 17:31
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-update-reduced-number-of-blocked-domains/52599/11

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/zahlenformat-darstellung-im-dashboard/52657/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants