Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start php session before generating output for API token #2147

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Start php session before generating output for API token #2147

merged 1 commit into from
Mar 16, 2022

Conversation

yubiuser
Copy link
Member

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Start php session before starting output for showing API token.

Fixes #2128

Thanks @regae

@yubiuser
Start php session before generating output for API token
77c7a12 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser linked an issue Mar 16, 2022 that may be closed by this pull request
Show API key "Not authorized!" caused by php output_buffering=Off #2128
Closed
@yubiuser yubiuser requested a review from a team March 16, 2022 13:14
@yubiuser yubiuser merged commit ceb2036 into devel Mar 16, 2022
@yubiuser yubiuser deleted the buffer_off branch March 16, 2022 18:14
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

This was referenced Apr 20, 2022
Merged
Merged
Closed
Merged
Merged
Merged
Open
Closed
Merged
@matt-oakes matt-oakes mentioned this pull request Apr 23, 2022
Merged
1 task
@bloopy-boi bloopy-boi bot mentioned this pull request Apr 23, 2022
Merged
1 task
This was referenced Apr 24, 2022
Merged
Merged
Closed
Closed
This was referenced Apr 26, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show API key "Not authorized!" caused by php output_buffering=Off
3 participants
@yubiuser @pralor-bot @PromoFaux