Add "Clients (over time)" graph #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Using absolute instead of relative numbers seems to give a more useful graph.
|
AzureMarker
suggested changes
Sep 23, 2017
scripts/pi-hole/js/index.js
Outdated
| @@ -642,7 +728,7 @@ $(document).ready(function() { | |||
| var m = parseInt(time[2], 10) || 0; | |||
| var from = padNumber(h)+":"+padNumber(m-5)+":00"; | |||
| var to = padNumber(h)+":"+padNumber(m+4)+":59"; | |||
| return "Forward destinations from "+from+" to "+to; | |||
| return "Client activity from "+from+" to "+to; | |||
There was a problem hiding this comment.
You flipped the forward destinations and client activity hover text
scripts/pi-hole/js/index.js
Outdated
| @@ -680,6 +766,64 @@ $(document).ready(function() { | |||
| }); | |||
|
|
|||
| // Pull in data via AJAX | |||
| updateClientsOverTime(); | |||
There was a problem hiding this comment.
This should be switched with the forward destinations call on line 827.
scripts/pi-hole/js/index.js
Outdated
| var m = parseInt(time[2], 10) || 0; | ||
| var from = padNumber(h)+":"+padNumber(m-5)+":00"; | ||
| var to = padNumber(h)+":"+padNumber(m+4)+":59"; | ||
| return "Forward destinations from "+from+" to "+to; |
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
previously approved these changes
Sep 23, 2017
|
With the change in excluding clients from the client graph in the corresponding FTL PR, this PR should change the settings page info for the excluded domains section. |
…like we do it already for the main graph) Signed-off-by: DL6ER <dl6er@dl6er.de>
…o new/clientsovertime
AzureMarker
approved these changes
Sep 30, 2017
DL6ER
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
This adds an over time graph for the individual clients that used the Pi-hole as their DNS server.
The "design" of the new graph has still to be improved - this is only a proof-of-concept screenshot:
Important: Needs up-to-date version of
FTLon custom branchnew/clientsovertimeThis template was created based on the work of
udemy-dl.