Whitelist and Blacklist editing #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the change to 0.0.0.0 there will be no need for a password
Updates from using `whitelist.sh` and `blacklist.sh` to using `pihole`. Currently includes sudo in command, but after the scripts get updated with sudo checking that should not be needed.
Conflicts: list.php php/add.php php/sub.php
Only allows requests from http://pi.hole and http://<Pi's IP>
This was referenced May 8, 2016
It appears that sometimes the first time you open the page, the token is not synced correctly or something, causing the CSRF check to fail. Starting the session before any HTML is outputted seems to be a recommended first step to troubleshooting PHP session errors. I have tried to test this fix, but right now I don't know exactly what triggers the error.
Both failed CORS as both browsers, unlike Chrome, do not send `Origin` headers for same-origin requests. Now the scripts check if the `Host` header equals the IP of the Pi-hole. IE may require more fixing, as it's IE. :P
This fixes the fix. I still needed to account for `pi.hole` as a Host value.
If only Host was correct (FireFox and IE only set Host for same-origin requests) then it would still use the empty Origin header for the CORS response, leading to `Access-Control-Allow-Origin: `
IE would cache the list contents, so that if you updated the list it would not show up as changed.
Mainly changed from `document.getElementById("something")` to
`$(#something)`. Also changed the html and hide/show functions
as a result of the change.
Only activates when the input has focus.
They will pop back up again if you add another domain.
If the list became empty, the "Your $list is empty!" message would not pop up, since the fadeIn call is out of that scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
@pi-hole/dashboard