Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery inputmask #931

Merged
merged 3 commits into from
Apr 22, 2019
Merged

Remove jQuery inputmask #931

merged 3 commits into from
Apr 22, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 10, 2019

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix #928

This also removes a rather big library from the settings page, making the Pi-hole footprint somewhat smaller.

How does this PR accomplish the above?:

Remove the jQuery inputmask validator. Entered values are still validated in the background. Instead of preventing the user to be able to enter invalid data, we now shift the checking into the backend (where it is already happening) and display meaningful errors.

Custom 1 DNS server: 127.0.0.1#5353fff produces this error:
Screenshot from 2019-04-10 17-05-34

Custom 1 DNS server: 127.0.0#5353 produces this error:
Screenshot from 2019-04-10 17-05-48

What documentation changes (if any) are needed to support this PR?:

None

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Apr 10, 2019
@DL6ER DL6ER added this to the v4.3 milestone Apr 10, 2019
@DL6ER DL6ER requested a review from PromoFaux April 10, 2019 15:18
Signed-off-by: DL6ER <dl6er@dl6er.de>
AzureMarker
AzureMarker previously approved these changes Apr 11, 2019
@AzureMarker AzureMarker reopened this Apr 11, 2019
PromoFaux
PromoFaux previously approved these changes Apr 12, 2019
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER dismissed stale reviews from PromoFaux and AzureMarker via 4923a75 April 12, 2019 14:01
@AzureMarker AzureMarker reopened this Apr 13, 2019
@dschaper dschaper merged commit 1026359 into release/v4.3 Apr 22, 2019
@dschaper dschaper deleted the fix/ip-validator branch April 22, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants