Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Fix #928
This also removes a rather big library from the settings page, making the Pi-hole footprint somewhat smaller.
How does this PR accomplish the above?:
Remove the jQuery
inputmask
validator. Entered values are still validated in the background. Instead of preventing the user to be able to enter invalid data, we now shift the checking into the backend (where it is already happening) and display meaningful errors.Custom 1
DNS server:127.0.0.1#5353fff
produces this error:Custom 1
DNS server:127.0.0#5353
produces this error:What documentation changes (if any) are needed to support this PR?:
None