Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in PADDtiny (v3.3.1...v3.3.2) #127

Closed
christianboyle opened this issue Sep 18, 2020 · 2 comments · Fixed by #128
Closed

Regressions in PADDtiny (v3.3.1...v3.3.2) #127

christianboyle opened this issue Sep 18, 2020 · 2 comments · Fixed by #128

Comments

@christianboyle
Copy link
Contributor

Not sure if this was intentional or not, but 3.3.2 reverts all of the alignment changes we made in 3.3.1 and introduces some other issues:

  1. IPV4 address is now displaying a WiFi address 192.168.86.x rather than Ethernet 192.168.1.x/24
  2. There's an empty value displayed for IPV6 when previously it would be hidden if not in use.

Some of the "Stats" fields seem different too, maybe the MR that introduced these changes didn't rebase prior to the merge?

zz

@fullburnen
Copy link
Contributor

PR author here.

All section headings are now aligned on the left edge to match the other sizes. I agree that the version info should be shifted right to match.

FTL PID and DNSCache were replaced with the Top Dmn + Top Clnt / DHCP info display that is on the slim and regular.

@christianboyle
Copy link
Contributor Author

christianboyle commented Sep 18, 2020

@fullburnen

All section headings are now aligned on the left edge to match the other sizes.

Makes sense, not sure how I missed this before.

I agree that the version info should be shifted right to match.

👍

FTL PID and DNSCache were replaced with the Top Dmn + Top Clnt / DHCP info display that is on the slim and regular.

👍

Any thoughts on the IPV6 conditional display or IPV4 WiFi/Eth items?

fullburnen added a commit to fullburnen/PADD that referenced this issue Sep 18, 2020
Signed-off-by: fullburnen <fullburnen@protonmail.com>
fullburnen added a commit to fullburnen/PADD that referenced this issue Sep 20, 2020
Update version number to v3.3.3

Signed-off-by: fullburnen <fullburnen@protonmail.com>
dschaper added a commit that referenced this issue Sep 20, 2020
Issue #127: Resolve version alignment issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants