Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust overflow cutoff for PADDtiny, add handling for top_domain and … #170

Merged
merged 3 commits into from Aug 27, 2021

Conversation

christianboyle
Copy link
Contributor

@christianboyle christianboyle commented Aug 15, 2021

Currently we have a text overflow issue in PADDtiny when displaying long URLs.

The end result is that the first line of output is pushed off the top of the screen.

Since this could happen with any of the 4 fields that display URLs I went ahead and added the 2 fields we didn't have handling for previously (top_domain & top_client) and changed the cutoff value from 39 to 37.

first line pushed off top of screen on physical display:
IMG_0790

same thing broken in virtual display:
broken

notice the ellipsis doesn't work properly at cutoff of 39 (ellipsis overlaps the main section separator bars):
fixed-39

missing fields added, cutoff changed to 37 (the PR changes):
fixed-37

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

@christianboyle
Copy link
Contributor Author

Update:

It seems like the cutoff should be 38 rather than 37 to get maximum use of the available space (fixed in PR).

physical:
IMG_0791

virtual:
2021-08-15_07-32-56PM

@christianboyle
Copy link
Contributor Author

Update 2:

Working as expected with multiple overflowing lines.

physical:
IMG_0798

virtual:
fixed-virtual

@dschaper
Copy link
Member

Can you bump line 20 to version 3.6.2 and then we can set this for release.

@dschaper dschaper merged commit 00ec49d into pi-hole:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants