Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PADD status #182

Merged
merged 2 commits into from Jan 6, 2022
Merged

Fix PADD status #182

merged 2 commits into from Jan 6, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 5, 2022

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Fixes the reported status in PADD. After #4485 pihole status web does include the port FTL is listening on.
However, PADD checked for hard-coded "1" as return value.

How does this PR accomplish the above?:
Report Pi-hole as being active if the status is greater or equals "1" (which means FTL is listening on any port and blocking is not disabled)

Issue reported here: https://discourse.pi-hole.net/t/padd-v3-6-2-does-not-show-core-version-after-upgrading-to-pi-hole-core-v5-8/52257


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.

Signed-off-by: Christian König <ckoenig@posteo.de>
@DL6ER
Copy link
Member

DL6ER commented Jan 5, 2022

Please update the version to

padd_version="v3.6.3"

at the top of the file

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser marked this pull request as draft January 6, 2022 10:49
@yubiuser yubiuser marked this pull request as ready for review January 6, 2022 13:02
@DL6ER DL6ER merged commit 1ce1d33 into pi-hole:master Jan 6, 2022
@yubiuser yubiuser deleted the fix/status branch May 12, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants