Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 add howto run padd.sh with dockerized Pi-hole and remove link to wiki from README #208

Merged
merged 1 commit into from Aug 12, 2022

Conversation

thomasmerz
Copy link
Sponsor Contributor

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
This PR adds a new chapter in README how to use padd.sh with a dockerized Pi-hole installation. The user is given two examples for native docker and also for docker-compose.

This PR is a follow-up of PR #155

How does this PR accomplish the above?:
I've taken a screenshot of how README will look like after merging:

grafik

What documentation changes (if any) are needed to support this PR?:
A new chapter "Running Pi-hole in a Docker Container" has been added.

@thomasmerz
Copy link
Sponsor Contributor Author

@yubiuser , I found by accident this open PR. Can you please review and merge if you're happy with my addition? Thank you.

@yubiuser
Copy link
Member

One day we might get: pi-hole/docker-pi-hole#1105

@thomasmerz
Copy link
Sponsor Contributor Author

So should I close my PR as PADD will be fully integrated with Pi-hole?
Or are some lines in README regarding how to execute padd.sh still missing? 😉

@yubiuser
Copy link
Member

No, it's fine this PR is still in draft mode. Just remember to adjust the README once it's merged.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole FAQ section can be deleted, the link is death.

@thomasmerz
Copy link
Sponsor Contributor Author

No, it's fine this PR is still in draft mode. Just remember to adjust the README once it's merged.

pi-hole/docker-pi-hole#1105 (comment) 👍🏼

@yubiuser yubiuser changed the title 📝 add howto run padd.sh with dockerized Pi-hole and fix link to wiki 📝 add howto run padd.sh with dockerized Pi-hole and remove link to wiki from README Aug 12, 2022
@yubiuser yubiuser merged commit bb8bfcc into pi-hole:master Aug 12, 2022
@thomasmerz thomasmerz deleted the readme_add_docker branch August 12, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants