Use FTL's API endpoint to get Pi-hole's status #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)Please make sure you Sign Off all commits. Pi-hole enforces the DCO.
What does this PR aim to accomplish?:
Instead of using
pihole status web
to get the Pi-hole status, use the native FTL API endpoints>stats
and>dns-port
(pi-hole/FTL#1264) to determine Pi-hole's current status.Drawback of
pihole status web
is that it needssudo
powers to run the function. Calling the endpoints directly does not require elevated privileges.The logic is now the following (mimicy of
pihole status web
): If no FTL PID is found or the DNS part if Pi-hole is disabled, the status is "DNS offline". If this is not the case, everything depends onstatus
returned by>stats
. It can either be "enabled", "disabled" (blocking off) or "unknown".