Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the version comparison of the
PADD
versions. So far, we literally compare${padd_version}
with${padd_version_latest}
and if they differ, we assumePADD
is out of date.This PR does a conversion of the version string from
v.X.Y.Z
toX00Y00Z000
and really checks if${padd_version}
is less than${padd_version_latest}
.This has also the advantage that newer, local
PADD
versions (e.g. pre-release versions) do not trigger the "PADD is out of date" warning.Example: Current (remote) PADD version is v3.7.1. Local version is v3.8.0
By submitting this pull request, I confirm the following:
git rebase
)