Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PADD version comparison #238

Merged
merged 4 commits into from Jul 18, 2022
Merged

Conversation

yubiuser
Copy link
Member

  • What does this PR aim to accomplish?:

Improve the version comparison of the PADD versions. So far, we literally compare ${padd_version} with ${padd_version_latest} and if they differ, we assume PADD is out of date.
This PR does a conversion of the version string from v.X.Y.Z to X00Y00Z000 and really checks if ${padd_version} is less than ${padd_version_latest}.
This has also the advantage that newer, local PADD versions (e.g. pre-release versions) do not trigger the "PADD is out of date" warning.

Example: Current (remote) PADD version is v3.7.1. Local version is v3.8.0

Bildschirmfoto zu 2022-06-29 12-12-41


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

padd.sh Outdated Show resolved Hide resolved
@yubiuser
Copy link
Member Author

yubiuser commented Jul 1, 2022

Ok, stickler is failing as well...

Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested review from dschaper and a team July 4, 2022 22:12
Signed-off-by: Christian König <ckoenig@posteo.de>
padd.sh Show resolved Hide resolved
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from dschaper July 18, 2022 20:49
@yubiuser yubiuser merged commit 14632f1 into development Jul 18, 2022
@yubiuser yubiuser deleted the tweak_version_control branch July 18, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants