Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty line after IPv6 on tiny and regular #253

Merged
merged 1 commit into from Aug 19, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jul 27, 2022

  • What does this PR aim to accomplish?:

PR #226 fixed the left hand alignment of IPv6 on tiny and slim|regular. However, it introduced unnecessary spaces to the right which will be shown as empty line on screens with low width.
This PR removes the spaces.

Smallest tiny with 53x20, smallest regular with 60x22. Note: The vertical issue (#251) will be fixed later.

Before
Bildschirmfoto zu 2022-07-27 10-01-15

After
Bildschirmfoto zu 2022-07-27 10-01-42


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team July 27, 2022 08:05
@yubiuser yubiuser merged commit b14a97c into development Aug 19, 2022
@yubiuser yubiuser deleted the fix_ipv6_alignment branch August 19, 2022 18:04
@yubiuser yubiuser mentioned this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants