Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set local variables #255

Merged
merged 1 commit into from Aug 19, 2022
Merged

Allow to set local variables #255

merged 1 commit into from Aug 19, 2022

Conversation

yubiuser
Copy link
Member

  • What does this PR aim to accomplish?:

In POSIX, local (for variables) is undefined. However, most real-world shells support it.
https://github.com/koalaman/shellcheck/wiki/SC3043#exceptions

For core we decided to use local and suppress the warning. This PR does the same for PADD and sets a few variables to local.

The majority of the shown diffs is only indention change according to our editorconfig.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team July 29, 2022 20:40
@yubiuser yubiuser merged commit e8cc40e into development Aug 19, 2022
@yubiuser yubiuser deleted the allow_local branch August 19, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants