Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order network info in mini #272

Merged
merged 2 commits into from Dec 10, 2022
Merged

Re-order network info in mini #272

merged 2 commits into from Dec 10, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 26, 2022

What does this PR aim to accomplish?:

Removes interface and TX/RX info from PADD in size mini
Those were added by #233. In b375435 I reduced the number of lines by one to fit it in 18 lines (which is the smallest height for mini) by printing the IP next to the host name.

However, this will fail for long hostnames and/or long IPs.
image

Also the TX/RX won't fit if traffic increases

Screenshot at 2022-10-26 11-18-14


In summary, mini is just to small to add those infos - so remove them.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team October 26, 2022 09:09
@yubiuser yubiuser mentioned this pull request Oct 26, 2022
@dschaper
Copy link
Member

dschaper commented Nov 2, 2022

Would replacing IFace with NIC or something short be an option?

@yubiuser
Copy link
Member Author

yubiuser commented Nov 2, 2022

Probably. I already made some changes locally, but it doesn't look how I would like it to be. I'll convert to draft and re-request when I figured out a way to squeeze everything in.

@yubiuser
Copy link
Member Author

yubiuser commented Dec 6, 2022

With latest changes everything should fit.
Screenshot at 2022-12-06 22-25-28

@yubiuser yubiuser marked this pull request as ready for review December 6, 2022 21:27
@yubiuser yubiuser changed the title Remove interface and TX/RX info from mini Re-order network info in mini Dec 6, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2022-12-10 11-42-08

@yubiuser yubiuser merged commit 39d1183 into development Dec 10, 2022
@yubiuser yubiuser deleted the fix/mini branch December 10, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants