Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling of certain upstream DNS server #280

Merged
merged 2 commits into from Dec 10, 2022
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Dec 6, 2022

What does this PR aim to accomplish?:

Simplifies the upstream DNS server count/naming. We had special "names" for some upstream servers (Cloudflared, gateway) but the choice seems a bit arbitrary. If we had more than 8 upstream DNS server, we also would indicated this.

This PR allows only 2 cases now:

  1. exactly 1 server
  2. more than 1 server

P.S. Removes now unused variable $pi_gateway


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team December 6, 2022 21:44
@yubiuser yubiuser mentioned this pull request Dec 6, 2022
padd.sh Outdated Show resolved Hide resolved
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@DL6ER DL6ER merged commit 71d6c3a into development Dec 10, 2022
@DL6ER DL6ER deleted the no_special branch December 10, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants