New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly test for sysinfo files #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DL6ER
force-pushed
the
fix/sysinfo_files
branch
from
December 17, 2022 15:11
6b9729f
to
dda2ea8
Compare
Rebased on latest |
yubiuser
force-pushed
the
fix/sysinfo_files
branch
from
December 17, 2022 20:00
99e698f
to
87464ce
Compare
yubiuser
previously approved these changes
Dec 17, 2022
Merged
1 task
yubiuser
force-pushed
the
fix/sysinfo_files
branch
2 times, most recently
from
December 18, 2022 14:10
218591b
to
1a79e3b
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
yubiuser
force-pushed
the
fix/sysinfo_files
branch
from
December 23, 2022 20:47
1a79e3b
to
1fde2f1
Compare
Rebased on current |
rdwebdesign
approved these changes
Dec 23, 2022
One commit is mine too (41ce1c5) Approved, anyway. |
I know, but 1 is 1 less than two. So you are less "biased" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Add an alternative implementation for the issue that should be solved in #295
How does this PR accomplish the above?:
Do not assume files exist and silence the error later but only use files we know existing.
Link documentation PRs if any are needed to support this PR:
N/A
By submitting this pull request, I confirm the following:
git rebase
)