Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing dash for some options on the help text #361

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix the help text.

On the current code, the options -xoff and -yoff were changed to --xoff and --yoff (not sure which commit), so we need to change the help text.
Current help is showing these options with just one dash/hyphen.

How does this PR accomplish the above?

Changing from - to --.
(sometimes I hate this template...)

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@yubiuser
Copy link
Member

yubiuser commented Aug 1, 2023

It was changed with this commit
b28c112

I changed from single letter flags to whole words to better explain what each flag means. And for more than one letter flag, two dashes seem right

@yubiuser yubiuser merged commit 9b8dc56 into PADD_FTLv6 Aug 1, 2023
5 checks passed
@yubiuser yubiuser deleted the fix/PADDftl6_help branch August 1, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants