-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JScript disabled notification prompt. #47
Comments
I think it looks good, I'm sure the web design folks will comment in a bit, but it's the weekend so they may be not around. Can you PR the code changes? |
Sure, have a look at the project here: https://github.com/Verpz/Javascript-Disabled-Warning-Popup |
The only thing I can think of off the top of my head would be the issue of adding another CDN into the mix, but that's not something I deal with. (I'm not a full stack developer, still learning front end...) Your issue will get a look over though and we'll let you know. Thanks! |
Ok, thanks, still want me to PR? You can also use a local css file if you would rather. |
Yes, please PR... |
Just wondering how long on average it takes for a new release of Pi-Hole to come out. |
The next release will be soon™ In all seriousness, it depends on the amount of activity, and what has been pushed into the development branch. We haven't committed to a regular release schedule, but if there is a release, it's generally on a Sunday. |
Okay, thanks :) |
When JS is disabled, the dashboard breaks. I made a project that partially solves this issue.
Thoughts? If you like it, I can commit it in. (I do a lot of web stuff, so I disable my JS a lot for testing and it's really annoying when I load this console wait one minute for nothing to happen and then realise that JS is off.)
Sorry if this comes across as advertising, it's not. I have this on my local version of Pi hole, I'm just seeing if it interests anyone else.
The text was updated successfully, but these errors were encountered: