Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JScript disabled notification prompt. #47

Closed
Verpz opened this issue Feb 27, 2016 · 8 comments
Closed

JScript disabled notification prompt. #47

Verpz opened this issue Feb 27, 2016 · 8 comments

Comments

@Verpz
Copy link
Contributor

Verpz commented Feb 27, 2016

When JS is disabled, the dashboard breaks. I made a project that partially solves this issue.

Thoughts? If you like it, I can commit it in. (I do a lot of web stuff, so I disable my JS a lot for testing and it's really annoying when I load this console wait one minute for nothing to happen and then realise that JS is off.)
Sorry if this comes across as advertising, it's not. I have this on my local version of Pi hole, I'm just seeing if it interests anyone else.
Pi-Hole Console

@dschaper
Copy link
Member

I think it looks good, I'm sure the web design folks will comment in a bit, but it's the weekend so they may be not around. Can you PR the code changes?

@Verpz
Copy link
Contributor Author

Verpz commented Feb 27, 2016

Sure, have a look at the project here: https://github.com/Verpz/Javascript-Disabled-Warning-Popup

@dschaper
Copy link
Member

The only thing I can think of off the top of my head would be the issue of adding another CDN into the mix, but that's not something I deal with. (I'm not a full stack developer, still learning front end...) Your issue will get a look over though and we'll let you know. Thanks!

@Verpz
Copy link
Contributor Author

Verpz commented Feb 27, 2016

Ok, thanks, still want me to PR?

You can also use a local css file if you would rather.

@dschaper
Copy link
Member

Yes, please PR...

@dschaper dschaper changed the title Thoughts? JScript disabled notification prompt. Feb 28, 2016
@Verpz
Copy link
Contributor Author

Verpz commented Feb 29, 2016

Just wondering how long on average it takes for a new release of Pi-Hole to come out.

@PromoFaux
Copy link
Member

The next release will be soon™

In all seriousness, it depends on the amount of activity, and what has been pushed into the development branch. We haven't committed to a regular release schedule, but if there is a release, it's generally on a Sunday.

@Verpz
Copy link
Contributor Author

Verpz commented Feb 29, 2016

Okay, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants