Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken deploy step #88

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix broken deploy step #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/actions/merge-and-push/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ inputs:
imagename:
required: true
description: The name of the image to push
platform:
required: true
description: The platform to push the image for
registry:
required: true
description: The Registry to push the image to
Expand All @@ -19,7 +16,6 @@ runs:
shell: bash
run: |
[[ "${{ inputs.imagename }}" ]] || { echo "imagename input is empty" ; exit 1; }
[[ "${{ inputs.platform }}" ]] || { echo "platform input is empty" ; exit 1; }
[[ "${{ inputs.registry }}" ]] || { echo "registry input is empty" ; exit 1; }

-
Expand All @@ -37,12 +33,12 @@ runs:
# type=ref,event=branch means that a tag is applied when the workflow is triggered by a push to a branch
# type=ref,event=tag means that a tag is applied when the workflow is triggered by a push to a tag
tags: |
type=schedule,suffix=-${{ inputs.platform }},enable=${{ github.event_name == 'schedule' }}
type=ref,event=branch,suffix=-${{ inputs.platform }},enable=${{ github.event_name != 'schedule' }}
type=ref,event=tag,suffix=-${{ inputs.platform }}
type=schedule,enable=${{ github.event_name == 'schedule' }}
type=ref,event=branch,enable=${{ github.event_name != 'schedule' }}
type=ref,event=tag
-
name: Create manifest list and push to repository
working-directory: /tmp/digests/${{ inputs.registry }}/${{ inputs.platform }}
working-directory: /tmp/digests/${{ inputs.registry }}
# When using composite actions, you have to specify the shell. As you
# don’t specify a runner type in composite actions, you need to specify
# the shell instead for each action.
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ftl-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,10 @@ jobs:
uses: ./.github/actions/merge-and-push
with:
imagename: ${{ env.DOCKER_REGISTRY_IMAGE }}
platform: alpine
registry: dockerhub
-
name: Collect and push (GitHub Container Registry)
uses: ./.github/actions/merge-and-push
with:
imagename: ${{ env.GITHUB_REGISTRY_IMAGE }}
platform: alpine
registry: ghcr
Loading