Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS1 and DNS2 environment variables do not work as documented #55

Closed
gotiniens opened this issue Oct 8, 2016 · 1 comment
Closed

DNS1 and DNS2 environment variables do not work as documented #55

gotiniens opened this issue Oct 8, 2016 · 1 comment

Comments

@gotiniens
Copy link

gotiniens commented Oct 8, 2016 •
edited

The documentation suggests that these variables set the upstream DNS server to use for resolving. Except after starting my image with these variables I get the following in /etc/dnsmasq.d/01-pihole.conf

server=8.8.8.8 server=8.8.4.4
I would expect the values of the environment variables.
@diginc diginc closed this as completed in 61da6ce Oct 8, 2016
diginc added a commit that referenced this issue Oct 8, 2016
@diginc
Merge pull request #56 from diginc/fix_dns_env_vars
beb364d 
fixes #55 DNS1 & DNS2 bug
@diginc
Copy link
Collaborator

diginc commented Oct 8, 2016

Hey, good catch. Sorry for the regression, I did not have a test around those variables but the fix I implemented does so this shouldn't happen again. The new fixed version of the containers should be building now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diginc @gotiniens