Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Updates #97

Closed
diginc opened this issue Jan 23, 2017 · 2 comments
Closed

Readme Updates #97

diginc opened this issue Jan 23, 2017 · 2 comments

Comments

@diginc
Copy link
Collaborator

diginc commented Jan 23, 2017

Need some post-#84 accuracy and improvements to the README.md / documentation and linked scripts. Thoughts so far:

  • Review this statement for accuracy: "Upgrading If you try to use pi-hole -up it will fail." since .git folder data is present now.
    • needs updates to any similar statements to strongly suggest the 'docker way' of upgrading, or at least to start from scratch if you have any issues around upgrading.
  • A docker hub comment suggested adding --restart=always to the docker run command. 👍
    • Should add to the scripts / docker-compose files too
  • Update docker-compose files' schema #86 could fall under this umbrella

Feel free to add any suggestions.

@diginc
Copy link
Collaborator Author

diginc commented Jan 26, 2017

Trying to run the container after docker swarm init fails because of cap_add=NET_ADMIN being broken for swarm. Symptoms are: The container starts, docker userland proxy binds to 53, but DNS on 53 just doesn't work. I'll document as a known issue / FAQ somewhere.

@diginc
Copy link
Collaborator Author

diginc commented Feb 9, 2017

#106 resolves everything but documenting the docker swarm init limitations

@diginc diginc closed this as completed Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant