Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to mention minimum required docker version #1082

Merged
merged 2 commits into from
May 23, 2022

Conversation

canepan
Copy link
Contributor

@canepan canepan commented May 2, 2022

Signed-off-by: Nicola Canepa nicola.canepa.74@gmail.com
Mention the required update to docker.io in additon to libseccomp2 on ARM

Description

According to my experience and to some other reports, updating libseccomp2 is not enough if Docker is at version 18 (the one available with Buster/ARM)

Motivation and Context

Improve the documentation and improve user experience/troubleshooting

How Has This Been Tested?

SImple update to the README file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: Nicola Canepa <nicola.canepa.74@gmail.com>
Mention the required update to docker.io in additon to libseccomp2 on ARM
@canepan canepan mentioned this pull request May 2, 2022
6 tasks
README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux self-requested a review May 23, 2022 16:16
@PromoFaux PromoFaux merged commit 8cedb5b into pi-hole:dev May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants