Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default debian to bullseye. Update README to describe docker tags. #1084

Merged

Conversation

lightswitch05
Copy link
Member

Description

It looks like Bullseye is already the default (only) debian version we are using - so bump the other defaults to bullseye as well.

Also, update the README to better match the current docker tagging pattern.

Motivation and Context

Mostly just some cleanup as I catch back up on this project

How Has This Been Tested?

No testing other then Github Actions - the defaults shouldn't really change anything functional since we're already building bullseye images.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lightswitch05 lightswitch05 requested a review from a team May 3, 2022 02:42
@lightswitch05 lightswitch05 force-pushed the feature/update-default-debian-to-bullseye branch from 6e52732 to 6e36311 Compare May 3, 2022 02:49
|---------------------|--------------------------------------------------------------------------------------------------------------------------------------------|
| `latest` | Always latest release |
| `2022.04` | Date-based release that can receive bugfix updates |
| `2022.04.1` | A specific image that will not receive updates |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands, a 2022.04.1 will not also tag 2022.04 again. Maybe it should (I think most people just use latest in any case

But thanks for looking over this section - I completely didn't see it before!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like it if it did. That's how a few images I use do it. So you can use 2022.04 and always have the latest patches/fixes.

Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@PromoFaux PromoFaux merged commit ad9d7cb into pi-hole:dev May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants