Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python dependency - urllib3 & requests #1128

Merged

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Jul 5, 2022

Description

Update Python dependency - urllib3 & requests

  • Update urllib3 from v1.25.9 to v1.26.5
  • Update requests from v2.22.0 to v2.28.1

Motivation and Context

There's a medium severity CVE in urllib3, before v1.26.5, but we can't
only just update urllib3 because there will be a dependency conflict.
requests also needs to be updated.

CVE reference:

https://www.cve.org/CVERecord?id=CVE-2021-33503

An issue was discovered in urllib3 before 1.26.5. When provided with a
URL containing many @ characters in the authority component, the
authority regular expression exhibits catastrophic backtracking,
causing a denial of service if a URL were passed as a parameter or
redirected to via an HTTP redirect.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

- Update urllib3 from v1.25.9 to v1.26.5
- Update requests from v2.22.0 to v2.28.1

There's a medium severity CVE in urllib3, before v1.26.5, but we can't
only just update urllib3 because there will be a dependency conflict.
requests also needs to be updated.

CVE reference:

https://www.cve.org/CVERecord?id=CVE-2021-33503

> An issue was discovered in urllib3 before 1.26.5. When provided with a
> URL containing many @ characters in the authority component, the
> authority regular expression exhibits catastrophic backtracking,
> causing a denial of service if a URL were passed as a parameter or
> redirected to via an HTTP redirect.

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux merged commit d0b6c21 into pi-hole:dev Jul 6, 2022
@PeterDaveHello PeterDaveHello deleted the update-python-dependency branch July 6, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants