Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure FTL's MACVENDORDB setting to "/macvendor.db" on startup #1301

Merged
merged 1 commit into from Jan 23, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Discovered while troubleshooting #1299 (See comment)

We used to symlink this file, however I hadn't realised at the time it was configurable in FTL's config (RTFM, Adam). Setting the config option is performed during the ensure_basic_configuration step, and is ignored if a user has passed in their own FTLCONF_MACVENDORDB environment variable


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

…b. If user is passing in their own location, then we honour that.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux merged commit ad6b8a6 into dev Jan 23, 2023
@PromoFaux PromoFaux deleted the ln-fallback branch January 23, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant