Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IP V6 lookup #266

Merged
merged 2 commits into from
Apr 25, 2018
Merged

fix IP V6 lookup #266

merged 2 commits into from
Apr 25, 2018

Conversation

diginc
Copy link
Collaborator

@diginc diginc commented Apr 21, 2018

Forgot to add the lookup fix from #199 (comment)

Description

The origional IPv6 lookup command in the readme/start script was naive in beliving the IP would have a somewhat static column position. It seems to vary by OS distribution but it always has 'src' in front so this awk command looks for src column +1

Motivation and Context

Better IPv6 user experience

How Has This Been Tested?

  • Pipe cmd was tested with the output ipv6 commands.
  • Not fully tested until travis runs (editing on web)
  • I do not have IPv6 setup properly on my network so I suck at dog fooding the IPv6 feature, help appreciated in testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have updated the documentation accordingly.

@diginc diginc merged commit 9948388 into dev Apr 25, 2018
@diginc diginc deleted the fix_ipv6_lookup branch April 25, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant