Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armhf support #28

Closed
wants to merge 1 commit into from
Closed

armhf support #28

wants to merge 1 commit into from

Conversation

soredake
Copy link
Contributor

@soredake soredake commented Aug 5, 2016

No description provided.

@diginc
Copy link
Collaborator

diginc commented Aug 5, 2016

Sweet! Funny timing because I was working on the same thing last night for #2, I just didn't get my docker image running due to an error when running with docker run -d. That might not be related to the image its self though since I'm running hypriot for the first time. I'll try this out tonight to see if this is any different.

Are you using hypriot and able to run the built image successfully?

@soredake
Copy link
Contributor Author

soredake commented Aug 5, 2016

No, i tested build and run on raspberrypi2

@ghost
Copy link

ghost commented Aug 27, 2016

I've successfully built your code doing minor changes to debian.docker and docker_run.sh. I've also built an armhf version of tini. Built it on hypriot 0.8 on a Pi3. Works quite well. Let me know if you are interested in the changes I've made (not much, really).

@diginc
Copy link
Collaborator

diginc commented Aug 27, 2016

@soredake - Sorry for the delay in getting back to you - when I tested this I think the path on line 55 was a missing file (I think you meant COPY ./debian-armhf/start.sh /). Also could you re-open this pull request against the dev branch?

Master branch auto-rebuilds all the docker images again so I'm trying to only merge to it when changes actually occur to the docker images (I'll need to add in new test/builds for arm)

@ufud-org cool, I'd be curious to see what you have! Please do open a pull request (preferably to the dev branch as base).

I wanted to clean/optimize things a little bit before adding 2 more images for arm, like by not adding another duplicate (less duplication = less maintenance) start.sh script (by using ENV vars in different Dockerfiles. I also wanted to test out using ONBUILD to also reduce duplicative Dockerfile code. I'd be OK doing this after merging an initial dockerfile for arm though.

@diginc diginc closed this Aug 27, 2016
@diginc
Copy link
Collaborator

diginc commented Aug 27, 2016

I merged #30 so you probably don't need to re-open the pull request against dev branch.

@ghost
Copy link

ghost commented Aug 28, 2016

I merged #30 so you probably don't need to re-open the pull request against dev branch.

that's great news. can't wait to beta-test this once it comes available in master.

This was referenced Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants