Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI, CD, Python3, and PipEnv #552

Merged
merged 18 commits into from
Feb 3, 2020
Merged

CircleCI, CD, Python3, and PipEnv #552

merged 18 commits into from
Feb 3, 2020

Conversation

diginc
Copy link
Collaborator

@diginc diginc commented Jan 4, 2020

Circle CI based deployment "Hello World". Dry mode is currently being used while debugging everything. Outstanding questions / To do items

  1. Non-prod image destination? Should https://hub.docker.com/r/pihole/pihole/tags be only production builds?
  2. Branch filtering ? It'll auto deploy absolutely any branch currently, would just certain prefixes be better? like dev, rc-*, release-*
  3. Do tags work for prod releases as expected with this new code. I plan on testing this with dry-run mode still enabled (maybe my diginc/docker-pi-hole fork would be better to test that on to avoid pinging people with fake new releases)

Example output at the end of circle-ci when the deploy script runs:

========================== 35 passed in 21.01 seconds ==========================
Login Succeeded
Using the branch (deploy-images-from-ci) for deployed image version since not passed in
# DEPLOYING:
version: deploy-images-from-ci
branch: deploy-images-from-ci
DRY RUN: echo 
Example tagging: docker tag pihole:armhf pihole/pihole:deploy-images-from-ci_amd64
tox
docker tag pihole:v4.3.2_armhf pihole/pihole:deploy-images-from-ci_armhf
docker push pihole/pihole:deploy-images-from-ci_armhf
docker tag pihole:v4.3.2_amd64 pihole/pihole:deploy-images-from-ci_amd64
docker push pihole/pihole:deploy-images-from-ci_amd64
docker tag pihole:v4.3.2_aarch64 pihole/pihole:deploy-images-from-ci_aarch64
docker push pihole/pihole:deploy-images-from-ci_aarch64
docker manifest create --amend pihole/pihole:deploy-images-from-ci pihole/pihole:deploy-images-from-ci_armhf pihole/pihole:deploy-images-from-ci_amd64 pihole/pihole:deploy-images-from-ci_aarch64
docker manifest annotate pihole/pihole:deploy-images-from-ci pihole/pihole:deploy-images-from-ci_armhf --os linux --arch arm
docker manifest annotate pihole/pihole:deploy-images-from-ci pihole/pihole:deploy-images-from-ci_amd64 --os linux --arch amd64
docker manifest annotate pihole/pihole:deploy-images-from-ci pihole/pihole:deploy-images-from-ci_aarch64 --os linux --arch arm64
docker manifest push pihole/pihole:deploy-images-from-ci

Signed-off-by: Adam Hill <adam@diginc.us>
…mages-from-ci

Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
@diginc diginc changed the base branch from master to dev January 4, 2020 18:40
@dschaper
Copy link
Member

dschaper commented Jan 5, 2020

Left some comment on MM.

Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
Signed-off-by: Adam Hill <adam@diginc.us>
@diginc diginc force-pushed the deploy-images-from-ci branch 2 times, most recently from 9ce1ecb to e0b8bef Compare January 31, 2020 02:25
- Tox py3.7 + pipenv
- Python3 Dockerfile.py
- Dockerfile.py tags remote instead of just local image names now
- Circle.sh instead of in-line circle.yml script breakout
- probably other stuff I forgot
- Docker images build during the tests should hopefullly now be available at the deploy job workflow thanks to shared docker layers.
- Rename aarch64 to arm64 to reduce custom map
Signed-off-by: Adam Hill <adam@diginc.us>
@diginc diginc changed the title Deploy images from CircleCI CircleCI, CD, Python3, and PipEnv Jan 31, 2020
Signed-off-by: Adam Hill <adam@diginc.us>
@diginc diginc merged commit 8bfe969 into dev Feb 3, 2020
@diginc diginc deleted the deploy-images-from-ci branch February 3, 2020 21:37
@diginc diginc mentioned this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants