Use the namespace from secrets so others can build too. #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
dschaper
commented
Oct 3, 2021
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
PromoFaux
reviewed
Oct 3, 2021
PromoFaux
approved these changes
Oct 3, 2021
PromoFaux
requested changes
Oct 3, 2021
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
dschaper
force-pushed
the
fix/docker-namespace
branch
from
6b0466b
to
aefeb2b
Compare
PromoFaux
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use DOCKERHUB_USER Instead of hard code
pihole/piholefor the namespace.Motivation and Context
Forks of this repo couldn't build as they would try to push to our namespace and fail.
How Has This Been Tested?
Build it.
Types of changes
Checklist: