Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client.md #467

Closed
wants to merge 1 commit into from
Closed

Update client.md #467

wants to merge 1 commit into from

Conversation

pabz99
Copy link

@pabz99 pabz99 commented Jan 29, 2021

Tried to make some steps a bit more beginner proof.

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues

How does this PR accomplish the above?:
A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix

What documentation changes (if any) are needed to support this PR?:
A detailed list of any necessary changes


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.

Tried to make some steps a bit more beginner proof.
@netlify
Copy link

netlify bot commented Jan 29, 2021

Deploy preview for pihole-docs ready!

Built with commit 13c941c

https://deploy-preview-467--pihole-docs.netlify.app

@pralor-bot
Copy link
Collaborator

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/wireguard-wg0-conf-not-persistent-after-server-restart/43709/14

@yubiuser
Copy link
Member

Thanks for the PR.

Shutdown the server before making changes to the configuration file:

This is only necessary, if SaveConfig = true is set.
Before adding the changes you made, I would rather discuss if the SaveConfig should be removed.

@DL6ER
Copy link
Member

DL6ER commented Jan 29, 2021

I agree with the idea of just removing SaveConfig. Users may not expect this to work like it does (replace the config on restart/stop)

@yubiuser
Copy link
Member

@pabz99

Could you please change the PR accordingly? Or close this one and open a new one with only the SaveConfig removed?

If you want me to do it that's also fine.

@pabz99
Copy link
Author

pabz99 commented Feb 1, 2021

@yubiuser will look into it today!

I do notice that a lot of guides do put in SaveConfig = true. Shouldnt we then just adjust the server part a bit too and leave it in? Have to admit though that I'm not sure to what the actual function of it is or how it works.

@pabz99
Copy link
Author

pabz99 commented Feb 1, 2021

@yubiuser & @DL6ER : very stupid question, but how do I update my own commit? Tried to edit it in Github Editor, but it says I need to be on that branch before I can edit it.

@yubiuser
Copy link
Member

yubiuser commented Feb 1, 2021

How did you do your first commit? I do all my PRs local on my PC and push those to my fork of the Pi-hole repository.

I would revert the last commit and do a next commit.

@dschaper
Copy link
Member

dschaper commented Mar 6, 2021

@pabz99 Update?

@yubiuser
Copy link
Member

yubiuser commented Oct 3, 2021

Closing due to inactivity. Feel free to re-open anytime.

@yubiuser yubiuser closed this Oct 3, 2021
@pralor-bot
Copy link
Collaborator

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-unbound-wireguard-dns-not-working/54233/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants