Skip to content

Commit

Permalink
Skip the required ports check if installed in docker container. Unpri…
Browse files Browse the repository at this point in the history
…v'ed containers do not have access to the information required to resolve the service name listening - and the container should not start if there was a port conflict anyway (#4536)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
  • Loading branch information
PromoFaux committed Jan 8, 2022
1 parent 0124e49 commit 3097c8f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion advanced/Scripts/piholeDebug.sh
Expand Up @@ -787,7 +787,9 @@ check_networking() {
detect_ip_addresses "6"
ping_gateway "4"
ping_gateway "6"
check_required_ports
# Skip the following check if installed in docker container. Unpriv'ed containers do not have access to the information required
# to resolve the service name listening - and the container should not start if there was a port conflict anyway
[ -z "${PIHOLE_DOCKER_TAG}" ] && check_required_ports
}

check_x_headers() {
Expand Down

0 comments on commit 3097c8f

Please sign in to comment.