Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing Firefox to switch to DoH does not work by default #3167

Closed
3 tasks done
luzat opened this issue Feb 25, 2020 · 13 comments
Closed
3 tasks done

Preventing Firefox to switch to DoH does not work by default #3167

luzat opened this issue Feb 25, 2020 · 13 comments
Assignees
Labels
Investigating Open issue or bug, under investigation triage: Issue User Filled out Issue Template

Comments

@luzat
Copy link

luzat commented Feb 25, 2020

In raising this issue, I confirm the following:

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:

When runnig a query (dig -t A use-application-dns.net, dig -t AAAA use-applications-dns.net) against Pi-hole I expect to get NXDOMAIN (or similar) to indicate that DoH should not be used by Firefox (canary domain).

Actual behaviour:

0.0.0.0 and :: respectively are returned.

Steps to reproduce:

Install most recent Pi-hole (9e49077). /etc/dnsmasq.d/01-pihole.conf will contain server=/use-application-dns.net/. Make sure Pi-hole is your resolve and try to resolve use-application-dns.net.

Debug token provided by uploading pihole -d log:

https://tricorder.pi-hole.net/1xa35wpouj

Troubleshooting undertaken, and/or other relevant information:

The problem seems to be that blacklists take place first and the default list contains a blacklist entry in StevenBlack's list. Adding a whitelist entry for use-application-dns.net makes the resolver return NXDOMAIN anyway. Maybe this should be the default; otherwise the setting in 01-pihole.conf introduced by #2916 is probably useless by default.

@dschaper
Copy link
Member

Thanks for the report, can you provide a debug run token so we can see if the configs are applied correctly?

@dschaper
Copy link
Member

Contacting the list maintainer as well.

StevenBlack/hosts#1172

@luzat
Copy link
Author

luzat commented Feb 25, 2020

Added the debug token.

@dschaper dschaper added triage: Issue User Filled out Issue Template Investigating Open issue or bug, under investigation labels Feb 25, 2020
@press5
Copy link

press5 commented Feb 26, 2020

I ran into the same issue; in a fresh pihole install, there are entries in gravity.list and list.preEventHorizon which override the directive server=/use-application-dns.net/ in /etc/dnsmasq.d/01-pihole.conf and make it erroneously return 0.0.0.0.

List maintainers should remove entries for use-application-dns.net.

@dschaper
Copy link
Member

Workarounds are to either use BLOCKINGMODE=NXDOMAIN or to whitelist use-application-dns.net.

@press5
Copy link

press5 commented Feb 26, 2020

@dschaper as a temporary fix until the lists are updated to remove the entries?

@dschaper
Copy link
Member

Or as prevention from them being included in the future.

@press5
Copy link

press5 commented Feb 26, 2020

That makes sense. It seemed strange to me that pihole would include server=/use-application-dns.net/ out of the box only to nullify it in a list in the very next step...

@dschaper
Copy link
Member

Pi-hole does not curate or control the list content. They are maintained by community members.

@dschaper
Copy link
Member

This should be resolved with the lists mentioned.

StevenBlack/hosts#1172

Closing for now.

@Extarys
Copy link

Extarys commented Feb 27, 2020

Does this issue applies toV5 Beta and will this fix be made available on that version as well?

@dschaper
Copy link
Member

Beta 5 had it for a while now. No changes needed.

@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/use-application-dns-net/46131/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating Open issue or bug, under investigation triage: Issue User Filled out Issue Template
Projects
None yet
Development

No branches or pull requests

7 participants