-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation stops if no blocklist is selected. v5.0 #3336
Labels
Investigating
Open issue or bug, under investigation
Comments
castillo92
changed the title
Setup fails if no list is select
Installation stops if no blocklist is selected. v5.0
May 11, 2020
pvogt09
added a commit
to pvogt09/pi-hole
that referenced
this issue
May 15, 2020
… by user Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
8 tasks
PromoFaux
added a commit
that referenced
this issue
May 15, 2020
fix #3336 by creating adlist file even if no list was selected by user
Merged
This issue has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
PromoFaux
added a commit
that referenced
this issue
Aug 17, 2020
…lected Revert "fix #3336 by creating adlist file even if no list was selecte…
This issue has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In raising this issue, I confirm the following:
How familiar are you with the the source code relevant to this issue?:
1
Expected behaviour:
Doing a fresh install of PiHole 5.0, if we do not select any list in the initial setup, installation should continue, because we will add our custom list later.
Actual behaviour:
If we do not select any blocklist in the initial setup step, installation fails because
/etc/pihole/adlists.list
do not existInstall log:
Steps to reproduce:
Simply make a fresh install and leave initial blocklists unselected.
Troubleshooting undertaken, and/or other relevant information:
By selecting at least one list, the installation continues normally.
The text was updated successfully, but these errors were encountered: