Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation stops if no blocklist is selected. v5.0 #3336

Closed
3 tasks done
castillo92 opened this issue May 11, 2020 · 2 comments · Fixed by #3531
Closed
3 tasks done

Installation stops if no blocklist is selected. v5.0 #3336

castillo92 opened this issue May 11, 2020 · 2 comments · Fixed by #3531
Labels
Investigating Open issue or bug, under investigation

Comments

@castillo92
Copy link

castillo92 commented May 11, 2020

In raising this issue, I confirm the following:

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:
Doing a fresh install of PiHole 5.0, if we do not select any list in the initial setup, installation should continue, because we will add our custom list later.

Actual behaviour:

If we do not select any blocklist in the initial setup step, installation fails because /etc/pihole/adlists.list do not exist

Captura

Install log:

user-01@srv-01:~$ curl -sSL https://install.pi-hole.net | sudo bash
[sudo] password for user-01: 

  [✓] Root user check

        .;;,.
        .ccccc:,.
         :cccclll:.      ..,,
          :ccccclll.   ;ooodc
           'ccll:;ll .oooodc
             .;cll.;;looo:.
                 .. ','.
                .',,,,,,'.
              .',,,,,,,,,,.
            .',,,,,,,,,,,,....
          ....''',,,,,,,'.......
        .........  ....  .........
        ..........      ..........
        ..........      ..........
        .........  ....  .........
          ........,,,,,,,'......
            ....',,,,,,,,,,,,.
               .',,,,,,,,,'.
                .',,,,,,'.
                  ..'''.

  [i] Existing PHP installation detected : PHP version 7.4.5
  [✓] Disk space check
  [✓] Update local cache of available packages

  [✓] Checking apt-get for upgraded packages... 69 updates available
  [i] It is recommended to update your OS after installing the Pi-hole!

  [i] Installer Dependency checks...
  [✓] Checking for dhcpcd5
  [✓] Checking for git
  [✓] Checking for iproute2
  [✓] Checking for whiptail

  [i] SELinux not detected
  [i] Using upstream DNS: Cloudflare (1.1.1.1, 1.0.0.1)
chmod: cannot access '/etc/pihole/adlists.list': No such file or directory error when the file exists

Steps to reproduce:
Simply make a fresh install and leave initial blocklists unselected.

Troubleshooting undertaken, and/or other relevant information:
By selecting at least one list, the installation continues normally.

@castillo92 castillo92 changed the title Setup fails if no list is select Installation stops if no blocklist is selected. v5.0 May 11, 2020
@dschaper dschaper added the Investigating Open issue or bug, under investigation label May 11, 2020
pvogt09 added a commit to pvogt09/pi-hole that referenced this issue May 15, 2020
… by user

Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com>
PromoFaux added a commit that referenced this issue May 15, 2020
fix #3336 by creating adlist file even if no list was selected by user
@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

PromoFaux added a commit that referenced this issue Aug 17, 2020
…lected

Revert "fix #3336 by creating adlist file even if no list was selecte…
@pralor-bot
Copy link

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating Open issue or bug, under investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants