Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause button please? #449

Closed
richardhughes260 opened this issue Apr 8, 2016 · 11 comments
Closed

Pause button please? #449

richardhughes260 opened this issue Apr 8, 2016 · 11 comments
Labels
Enhancement Feature Request General Feature Requests

Comments

@richardhughes260
Copy link

richardhughes260 commented Apr 8, 2016

Feature Request:

Can you install a pause button?

Some sites I go to sense the ad blocker and do not render the content.

@PromoFaux
Copy link
Member

Check out this answer in the FAQ for a workaround!

We are looking at adding functionality like a disable button/ability to control scripts from web UI, but in the mean time, that work around should fix things....

@AzureMarker AzureMarker added Enhancement Feature Request General Feature Requests labels Apr 21, 2016
@rappo
Copy link

rappo commented Jun 2, 2016

@PromoFaux I know that you guys will be looking into adding a toggle to the UI, so I put a $40 bounty on this issue to show my gratitude / add encouragement :)

@richardhughes260
Copy link
Author

cool

On Thu, Jun 2, 2016 at 7:01 PM, David Rappo notifications@github.com
wrote:

@PromoFaux https://github.com/PromoFaux I know that you guys will be
looking into adding a toggle to the UI, so I put a $40 bounty on this
issue https://www.bountysource.com/issues/32758981-pause-button-please
to show my gratitude / add encouragement :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#449 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABfUYXlLJzKytmmmtBUWrt8BJEyS_6CAks5qH2C-gaJpZM4IDSeK
.

@dschaper
Copy link
Member

dschaper commented Jun 3, 2016

Thank you very much for you contribution!

@jacobsalmela
Copy link
Contributor

@rappo take a look at this, which I plan to put in the next release if it works well for everyone.

@PromoFaux PromoFaux changed the title Pause button please? Pause button please? [$40] Jul 18, 2016
@tuplink
Copy link
Contributor

tuplink commented Oct 21, 2016

SHELL PR
WEB PR

@dschaper
Copy link
Member

We need to be extremely careful with out code reviews, we've gotten a little lax and some bad bugs have gotten through. When we get time all PR's will be reviewed and we'll go from there. I don't know how Bounty works but if the bug is solved we'll work out something. This is FOSS code, anything else is just a great thing to be rewarded beyond regular recognition.

We have processes we follow and we will get to things as we can. I hope you understand that. Code changes this big are going to take a week or so to fully review. (We tend to have smaller PR's that have fewer changes in them just so we can go step by step and do our due dilligence.)

The PR's/commits and effort are greatly appreciated and will be forever in our hearts! So Thanks!

@rappo
Copy link

rappo commented Oct 22, 2016

@dschaper as the backer of the bounty, I didn't intend for the bounty to suggest it was higher priority or in any way should compromise what you guys do. From my point of view, I just wanted to see that feature built for all of us (but mostly for myself :D) and had neither the time nor the means to do it myself.

The bounty can be claimed automatically whenever this GH issue is closed.

And thank you all for the PR for this issue specifically, and for pi-hole in general 🎉

@PromoFaux
Copy link
Member

Implemented in 2.9.5/ web frontend 1.4.4

@tuplink, claim your bounty!

@tuplink
Copy link
Contributor

tuplink commented Oct 30, 2016

@PromoFaux please claim this. I have no intention of claming it.

@PromoFaux
Copy link
Member

PromoFaux commented Nov 2, 2016

@rappo Any idea why Bountysource is no longer updating our issues? Can't seem to uninstall/reinstall integration from the tools menu on your site... :)

@PromoFaux PromoFaux changed the title Pause button please? [$40] Pause button please? [$40 awarded] Mar 5, 2018
@PromoFaux PromoFaux changed the title Pause button please? [$40 awarded] Pause button please? Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature Request General Feature Requests
Projects
None yet
Development

No branches or pull requests

7 participants