Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default listening behavior of dnsmasq #1291

Merged
merged 2 commits into from Mar 3, 2017
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 3, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


Pulling against master

Default behavior is old behavior (listen on gravity interface (e.g. eth0), permit all origins)

Raspbian ships dnsmasq v2.72 which is problematic. Tested with v2.76 and didn't see any problems.

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added the Bug: fixed Contains a bug resolution label Mar 3, 2017
@PromoFaux
Copy link
Member

PromoFaux commented Mar 3, 2017

Approved

Approved with PullApprove

@PromoFaux
Copy link
Member

PromoFaux commented Mar 3, 2017

Approved

Approved with PullApprove

1 similar comment
@jacobsalmela
Copy link
Contributor

jacobsalmela commented Mar 3, 2017

Approved

Approved with PullApprove

@DL6ER DL6ER merged commit 051f463 into master Mar 3, 2017
@AzureMarker AzureMarker deleted the fix/defaultlisteningbehavior branch March 4, 2017 01:08
DL6ER added a commit to pi-hole/web that referenced this pull request Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: fixed Contains a bug resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants